Placing crude torch on leaves crashes game

[erikdk321]

Trying to fire up a path through a jungle has now crashed my game twice. Placing (crude) torches on leaves seems to be the cause.

Spoiler

Show

--- BEGIN ERROR REPORT d36c7e69 --------
Full report at:
C:\Users\erikb\AppData\Roaming\.minecraft\crash-reports\crash-2020-06-25_11.39.14-server.txt
Please show that file to Mojang, NOT just this screen!

Generated 25-06-20 11:39

-- System Details --
Details:
Minecraft Version: 1.5.2
Operating System: Windows 10 (amd64) version 10.0
Java Version: 1.8.0_241, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode), Oracle Corporation
Memory: 181806832 bytes (173 MB) / 434511872 bytes (414 MB) up to 1037959168 bytes (989 MB)
JVM Flags: 5 total; -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -XX:+UseConcMarkSweepGC -XX:+CMSIncrementalMode -XX:-UseAdaptiveSizePolicy -Xmx1G
AABB Pool Size: 5817 (325752 bytes; 0 MB) allocated, 5519 (309064 bytes; 0 MB) used
Suspicious classes: MCPatcherUtils, Config, JsonUtils, ...[com.google.gson.GsonBuilder, FieldNamingStrategy, TypeAdapterFactory, ...], [com.google.gson.annotations.SerializedName], [com.google.gson.internal.Excluder, ConstructorConstructor, ObjectConstructor, ...], [com.google.gson.internal.bind.JsonTreeWriter, JsonTreeReader, TypeAdapters, ...], [com.google.gson.reflect.TypeToken], [com.google.gson.stream.JsonWriter, JsonReader, MalformedJsonException, ...], [com.prupe.mcpatcher.cit.CITUtils, OverrideBase, ItemOverride, ...], [com.prupe.mcpatcher.ctm.CTMUtils, RenderBlockState, BlockOrientation, ...], [com.prupe.mcpatcher.mal.tile.TileLoader, IconAPI, V1]
IntCache: cache: 0, tcache: 0, allocated: 3, tallocated: 63
Profiler Position: N/A (disabled)
Vec3 Pool Size: 1276 (71456 bytes; 0 MB) allocated, 1076 (60256 bytes; 0 MB) used
Player Count: 1 / 8; [jc['Player294'/244, l='BTW 2: Electric Boogaloo', x=312,52, y=74,00, z=-194,61]]
Type: Integrated Server (map_client.txt)
Is Modded: Very likely; Jar signature invalidated

java.lang.NullPointerException
at FCBlockTorchFiniteBurning.a(FCBlockTorchFiniteBurning.java:46)
at abw.a(Chunk.java:608)
at aab.f(World.java:487)
at aab.setBlockWithNotify(World.java:4513)
at FCBlockTorchBase.a(FCBlockTorchBase.java:118)
at abw.a(Chunk.java:664)
at aab.f(World.java:487)
at aab.setBlockAndMetadataWithNotify(World.java:4508)
at FCItemPlacesAsBlock.a(FCItemPlacesAsBlock.java:84)
at FCItemBlockTorchBurning.a(FCItemBlockTorchBurning.java:23)
at wm.a(ItemStack.java:127)
at jd.a(ItemInWorldManager.java:395)
at jh.a(NetServerHandler.java:489)
at fr.a(Packet15Place.java:89)
at ch.b(SourceFile:59)
at jh.d(NetServerHandler.java:74)
at jk.b(NetworkListenThread.java:51)
at bjj.b(SourceFile:84)
at net.minecraft.server.MinecraftServer.r(SourceFile:480)
at net.minecraft.server.MinecraftServer.q(SourceFile:397)
at bjg.q(IntegratedServer.java:126)
at net.minecraft.server.MinecraftServer.run(SourceFile:331)
at gp.run(SourceFile:573)
--- END ERROR REPORT ea2da48e ----------

[FlowerChild]

I can't reproduce it, but I suspect what might be happening are that leaves are getting burned away as the torch itself is being placed, causing it to lose its mounting block before being fully initialized. Regardless, I put in a sanity check for next release that should prevent that happening.