Beginnersish coding discussion

[The_Ender_lord]

WOOHOO!
It taken about 2 hours but I've finally done it!
I've made a light blink on and off without ending.
:)

Here's the code for MPLAB X IDE v1.41:

Spoiler

Show

Code: Select all

#include <stdio.h>
#include <stdlib.h>
#include <p18f87k22.h>
#pragma config XINST = OFF
/*
 *
 */
void main(void) {
    int max = 10000;
    int i;

    LATD=0;
    TRISD=1;
    LATD=1;

  for(i = 0; i < max;i++){

    PORTDbits.RD1=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD1=0;
    }
    }

This is probably one of my biggest achievements yet.(I'm not much of an achiever)

I'm happy.

[Glace1221]

What am I looking at?

[The_Ender_lord]

You aren't required to comprehend it. Just to be able to understand the fact that its progress

[Gormador]

Nice ! It's a first time job but I see no reason why this shouldn't work !

May I ask what is your final goal in learning micro controller programing ?

[starkand]

KUDOS Ender_lord.
Let me just say, that's a huge beast you have there for prototyping "Hello 10" ;D

Is it just for an academic project or like your favourite hobby?

What am I looking at?

That's just a red stone clock btw. Remember when you built your first one?

[The_Ender_lord]

Stark: its just a hobby.
Gormador: i think my goal is to just learn how to read code.

[Gormador]

Seriously ? Then I don't understand. Because the ability to read code is useless if you don't intend to write some at some point.

EDIT : However, your professional life could require you to... yeah, my brain's not quite functional right now... sorry ^^

[The_Ender_lord]

Well, after a bit of googling I found a bit of code to create an infinite loop. After a bit of work i made this:

Spoiler

Show

Code: Select all

#include <stdio.h>
#include <stdlib.h>
#include <p18f87k22.h>
#pragma config XINST = OFF
/*
 *
 */
void main(void) {
    int max = 10000;
    int i;

    LATD=0;
    TRISD=1;
    LATD=1;

  for(i = 0; i < max;i++){

    PORTDbits.RD0=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD0=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD1=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD1=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD2=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD2=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD3=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD3=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD4=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD4=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD5=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD5=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD6=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD6=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD7=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD7=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD7=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD7=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD6=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD6=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD5=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD5=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD4=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD4=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD3=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD3=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD2=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD2=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD1=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD1=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD0=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD0=0;
    }

That is the code to make a line of 8 lights blink on and off in succession going one way and then the other.
I'm a bit annoyed as to how much code it takes for such a relatively simple task.

[ignika42]

I'm a bit annoyed as to how much code it takes for such a relatively simple task.

Reminds me of something my instructor told us in my first programming class, writing code is like explaining something to a child, you've gotta be very exact if you want them to understand you, because you can't assume they know anything.


Not familiar with micro-controller programming, but if you are going for an infinite loop, can't you just use a while loop?

Spoiler

Show

int y = 1;

while (y = 1)
{
//code that does stuff, aside from set y to something other than 1
}

[The_Ender_lord]

Yeah I've used while loops before.

[Glace1221]

You aren't required to comprehend it. Just to be able to understand the fact that its progress

Good enough for me! You have more patience than I do, I can tell you that! I don't think I would ever want to be a coder, even though I still might have to do some if I ever want to get into game making.

And,yes! I do remember the first redstone clock I made! I remember getting confused on how to get it going, too!

[The_Ender_lord]

How did redstone clocks get into it?

[Xekrom337]

How did redstone clocks get into it?

Becuase that's what that codey looking stuff does!

[The_Ender_lord]

...
Off-topic post in the off-topic forum is off-topic
...
...
...
OXYMORONS!

[Xekrom337]

...
Off-topic post in the off-topic forum is off-topic
...
...
...
OXYMORONS!

Wat.

Also, YOU DONT KNOW YOUR OWN CREATION, DO YOU? TIS NOW UNDER MY COMMAND! MUWAHAHAHHAHA!!!!!!!!

[SpaceGuyR]

I'm a bit annoyed as to how much code it takes for such a relatively simple task.

Sounds like you need to do functions and arguments. It should be possible to make one combined thing like "set light [position] [on/off]" and then you can easily do patterns instead of copying similar sections in main() every time.

[haphazardnuke]

I don't know microcontroller-specific code, but I know Java fairly well, so I can get the gist of that code.

Wouldn't it be simpler to do the following (in Java syntax, but it should be readable):

Code: Select all

while (true) {
     thingToToggle = 1;
     someWaitFunction();
     thingToToggle = 0;
}

The delay would only be needed if the LED toggles too fast to see. If the microcontroller has a built-in way to specify processing speed, you could just slow that down.

Regardless of all that, your first successful program is still a cool accomplishment. Tutorial code isn't supposed to be tidy or efficient anyway; those are things tutorial code writers expect you to do on your own, mostly. So, good job and welcome to the world of programming!

[starkand]

redstone? my bad, just throwing sand in the gears. nvm

Allow me to share a pseudo code block. Taking the ideas from SpaceGuyR and haphazardnuke we get:

Spoiler

Show

Code: Select all

void main(void) {
int max = 10000;
int i;

void rotatelamp(void) {
   static BYTE lamps = 0;              // the lamps state
   static int dir = 1;                 // a direction flag
   
   /*
   detect lamps overflow or underflow
   and re-set directions
   */

   if (dir == 1) {
      // rotate byte lamps;
   }
   if (dir == -1) {
      // counter rotate byte lamps;
   }
// PORTDbits = lamps;                   // taking advantage of a full byte write
}
//// I used TECH C compiler and it allowed me to write PORTD = lamps;
//// but in MC C the ports are named differently.


while(1) {                                    // a main loop,
   for(i = 0; i < max;i++){                   // some delay
   }
   rotatelamp();                              // and the lamp rotator pseudo function call
}
}

Another way to set a steady time-base is to use interrupt feature.

Having previous coding experience is a huge leap into MCU's ><
Looking at the thread title... I can't believe this is your first contact with coding syntax.

I'll be around in case you wanna trade any tips.
GL with the bit bang.

[The_Ender_lord]

I don't know microcontroller-specific code, but I know Java fairly well, so I can get the gist of that code.

Wouldn't it be simpler to do the following (in Java syntax, but it should be readable):

Code: Select all

while (true) {
     thingToToggle = 1;
     someWaitFunction();
     thingToToggle = 0;
}

The delay would only be needed if the LED toggles too fast to see. If the microcontroller has a built-in way to specify processing speed, you could just slow that down.

Regardless of all that, your first successful program is still a cool accomplishment. Tutorial code isn't supposed to be tidy or efficient anyway; those are things tutorial code writers expect you to do on your own, mostly. So, good job and welcome to the world of programming!

That was how I started coding.

[whitechaos35]

Well, after a bit of googling I found a bit of code to create an infinite loop. After a bit of work i made this:

Spoiler

Show

Code: Select all

#include <stdio.h>
#include <stdlib.h>
#include <p18f87k22.h>
#pragma config XINST = OFF
/*
 *
 */
void main(void) {
    int max = 10000;
    int i;

    LATD=0;
    TRISD=1;
    LATD=1;

  for(i = 0; i < max;i++){

    PORTDbits.RD0=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD0=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD1=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD1=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD2=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD2=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD3=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD3=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD4=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD4=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD5=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD5=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD6=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD6=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD7=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD7=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD7=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD7=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD6=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD6=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD5=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD5=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD4=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD4=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD3=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD3=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD2=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD2=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD1=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD1=0;
    }
      for(i = 0; i < max;i++){

    PORTDbits.RD0=1;
  }
  for(i = 0; i < max;i++){
    PORTDbits.RD0=0;
    }

That is the code to make a line of 8 lights blink on and off in succession going one way and then the other.
I'm a bit annoyed as to how much code it takes for such a relatively simple task.

Use bit shifting.

Spoiler

Show

Code: Select all

void main(void)
{
    byte dir = 1;
    byte portState = 0x10;

    LATD=0;
    TRISD=1;
    LATD=1;

    while(true)
    {
        PORTDbits = portState;
        if( dir == 1 )
        {
            if( portState == 0x01 )
            {
                dir = -1;
                portState <<= 1;
            }
            else
            {
                portState >>= 1;
            }
        }
        else
        {
            if( portState == 0x10 )
            {
                dir = 1;
                portState >>= 1;
            }
            else
            {
                portState <<= 1;
            }
        }
        delay();
    }
}